Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: components/sync/user_events/fake_user_event_service.h

Issue 2909283003: [Sync] Split UserEventService into interface and impl, add fake impl, add unit tests. (Closed)
Patch Set: Self review. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/user_events/fake_user_event_service.h
diff --git a/components/sync/user_events/fake_user_event_service.h b/components/sync/user_events/fake_user_event_service.h
new file mode 100644
index 0000000000000000000000000000000000000000..6a68747fc06dd4400999e08bc46601974b6a22cc
--- /dev/null
+++ b/components/sync/user_events/fake_user_event_service.h
@@ -0,0 +1,51 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SYNC_USER_EVENTS_FAKE_USER_EVENT_SERVICE_H_
+#define COMPONENTS_SYNC_USER_EVENTS_FAKE_USER_EVENT_SERVICE_H_
+
+#include <map>
+#include <memory>
+#include <set>
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "components/sync/protocol/user_event_specifics.pb.h"
+#include "components/sync/user_events/user_event_service.h"
+
+namespace syncer {
+
+class ModelTypeSyncBridge;
+
+class FakeUserEventService : public UserEventService {
Patrick Noland 2017/05/30 23:06:41 Can you add a short comment explaining why/how one
skym 2017/05/30 23:21:39 Done.
+ public:
+ FakeUserEventService();
+ ~FakeUserEventService() override;
+
+ // FakeUserEventService implementation.
Patrick Noland 2017/05/30 23:06:41 I think you mean UserEventService implementation?
skym 2017/05/30 23:21:39 Yeah, search/replace fail, done.
+ void RecordUserEvent(
+ std::unique_ptr<sync_pb::UserEventSpecifics> specifics) override;
+ void RecordUserEvent(const sync_pb::UserEventSpecifics& specifics) override;
+ void RegisterDependentFieldTrial(
+ const std::string& trial_name,
+ sync_pb::UserEventSpecifics::EventCase event_case) override;
+ base::WeakPtr<ModelTypeSyncBridge> GetSyncBridge() override;
+
+ const std::vector<sync_pb::UserEventSpecifics>& GetRecordedUserEvents() const;
+ const std::map<std::string, std::set<sync_pb::UserEventSpecifics::EventCase>>&
+ GetRegisteredDependentFieldTrials() const;
+
+ private:
+ std::vector<sync_pb::UserEventSpecifics> recorded_user_events_;
+ std::map<std::string, std::set<sync_pb::UserEventSpecifics::EventCase>>
+ registered_dependent_field_trials_;
+
+ DISALLOW_COPY_AND_ASSIGN(FakeUserEventService);
+};
+
+} // namespace syncer
+
+#endif // COMPONENTS_SYNC_USER_EVENTS_FAKE_USER_EVENT_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698