components/content_settings/core/common/content_settings_pattern.h - Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings_pattern.h

Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr (Closed)

Patch Set: remove more auto Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/content_settings/core/common/content_settings_pattern.h

diff --git a/components/content_settings/core/common/content_settings_pattern.h b/components/content_settings/core/common/content_settings_pattern.h

index 7d6fc8d00dd04d3e700a806eccc368907dd6f21e..fe292d53d47b017d8f5e4429b6177965c040ea52 100644

--- a/components/content_settings/core/common/content_settings_pattern.h

+++ b/components/content_settings/core/common/content_settings_pattern.h

@@ -7,6 +7,7 @@

#ifndef COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_CONTENT_SETTINGS_PATTERN_H_

#define COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_CONTENT_SETTINGS_PATTERN_H_

+#include <memory>

#include <string>

#include "base/gtest_prod_util.h"

@@ -136,7 +137,7 @@ class ContentSettingsPattern {

virtual ContentSettingsPattern Build() = 0;

};

- static BuilderInterface* CreateBuilder(bool use_legacy_validate);

+ static std::unique_ptr<BuilderInterface> CreateBuilder();

// The version of the pattern format implemented.

static const int kContentSettingsPatternVersion;