components/content_settings/core/common/content_settings_pattern_unittest.cc - Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings_pattern_unittest.cc

Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/content_settings/core/common/content_settings_pattern.cc ('K') | « components/content_settings/core/common/content_settings_pattern.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/common/content_settings_pattern_unittest.cc

diff --git a/components/content_settings/core/common/content_settings_pattern_unittest.cc b/components/content_settings/core/common/content_settings_pattern_unittest.cc

index d5aab80ab86a3d0d69fde5eef8acd91633b49729..69315df6b53afc3de6dd3cbf77bb80e027171da3 100644

--- a/components/content_settings/core/common/content_settings_pattern_unittest.cc

+++ b/components/content_settings/core/common/content_settings_pattern_unittest.cc

@@ -184,8 +184,7 @@ TEST(ContentSettingsPatternTest, FromURLNoWildcard) {

// The static Wildcard() method goes through a fast path and avoids the Builder

// pattern. Ensure that it yields the exact same behavior.

TEST(ContentSettingsPatternTest, ValidWildcardFastPath) {

- std::unique_ptr<ContentSettingsPattern::BuilderInterface> builder(

- ContentSettingsPattern::CreateBuilder(true));

+ auto builder = ContentSettingsPattern::CreateBuilder();

builder->WithSchemeWildcard()->WithDomainWildcard()->WithPortWildcard()->

WithPathWildcard();

ContentSettingsPattern built_wildcard = builder->Build();