chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.cc - Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.cc

Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/account_reconcilor_unittest.cc ('k') | components/content_settings/core/common/content_settings_pattern.h » ('j') | components/content_settings/core/common/content_settings_pattern.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.cc

diff --git a/chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.cc b/chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.cc

index 9dbab9f5369d1c9918268ac51a50c3a7ae768e4f..6195d92c398c09ded1b94e197d888fd8d67fa309 100644

--- a/chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.cc

+++ b/chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.cc

@@ -57,8 +57,7 @@ void PepperFlashContentSettingsUtils::FlashSiteSettingsToMediaExceptions(

MediaExceptions* media_exceptions) {

media_exceptions->clear();

- std::unique_ptr<ContentSettingsPattern::BuilderInterface> builder(

- ContentSettingsPattern::CreateBuilder(false));

+ auto builder = ContentSettingsPattern::CreateBuilder();

builder->WithSchemeWildcard()->WithPortWildcard();

for (ppapi::FlashSiteSettings::const_iterator iter = site_settings.begin();

iter != site_settings.end(); ++iter) {