Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
290923002:
Add missing include in SkBlurImage optimization (Closed)
|
Created:
6 years, 7 months ago by henrik.smiding Modified:
6 years, 7 months ago Reviewers:
vandebo (ex-Chrome), vapier, michaelpg, reed2, bsalomon_chromium, dgarrett, f(malita), Tom Hudson, dgreid, mtklein, reed1 CC:
skia-review_googlegroups.com Base URL:
https://skia.googlesource.com/skia.git@master Visibility:
Public. |
DescriptionAdd missing include in SkBlurImage optimization
Adds the missing include for smmintrin.h in the
SkBlurImage_opts_SSE2.cpp file.
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>;
BUG=chromium:374796
TEST=Unknown
Committed: http://code.google.com/p/skia/source/detail?r=14792
Patch Set 1 #Patch Set 2 : Added build checks... #
Total comments: 2
Messages
Total messages: 28 (0 generated)
lgtm
The CQ bit was checked by davidjames@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/henrik.smiding@intel.com/290923002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Add skia owners
This needs a BUG and TEST lines as well.
On 2014/05/19 18:16:31, dgreid wrote: > This needs a BUG and TEST lines as well. Added based on my best knowledge. This is fairly issue because of repeated failures of the ChromeOs canaries.
The CQ bit was checked by dgarrett@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/henrik.smiding@intel.com/290923002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by dgarrett@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/henrik.smiding@intel.com/290923002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
rubber stamp LGTM
The CQ bit was checked by vandebo@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/henrik.smiding@intel.com/290923002/20001
Message was sent while issue was closed.
Change committed as 14792
Message was sent while issue was closed.
https://codereview.chromium.org/290923002/diff/20001/src/opts/SkBlurImage_opt... File src/opts/SkBlurImage_opts_SSE2.cpp (right): https://codereview.chromium.org/290923002/diff/20001/src/opts/SkBlurImage_opt... src/opts/SkBlurImage_opts_SSE2.cpp:14: #include <smmintrin.h> This appears to be causing errors on Chromium's Mac builders: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu... Any idea what's going on?
Message was sent while issue was closed.
https://codereview.chromium.org/290923002/diff/20001/src/opts/SkBlurImage_opt... File src/opts/SkBlurImage_opts_SSE2.cpp (right): https://codereview.chromium.org/290923002/diff/20001/src/opts/SkBlurImage_opt... src/opts/SkBlurImage_opts_SSE2.cpp:14: #include <smmintrin.h> On 2014/05/20 22:05:01, Florin Malita wrote: > This appears to be causing errors on Chromium's Mac builders: > http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu... > > Any idea what's going on? The only way I can see this happening is if __SSE4_2__ is set, but not __SSE4_1__. Are you setting __SSE4_2__ manually or via -msse4? When you set -msse4 gcc will set all 'lower' SSE-level defines as well. This is what Skia's SSE-level detection is counting on. |
