Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6333)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h

Issue 2909123003: Replace deprecated base::NonThreadSafe in chrome/browser/safe_browsing in favor of SequenceChecker. (Closed)
Patch Set: remove include too Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
diff --git a/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h b/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
index 4ac99fa95fa06f513f5293006ee8b6e512ef54a5..c6172dafc3a3a9b704413cbef40b215d36e9d5ad 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
+++ b/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
@@ -9,7 +9,7 @@
#include "base/macros.h"
#include "base/run_loop.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "chrome/browser/safe_browsing/certificate_reporting_service.h"
#include "content/public/test/test_browser_thread.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -100,8 +100,7 @@ class RequestObserver {
// empty response. If Resume() is called before a request is made, then the
// request will not be delayed. If not delayed, it can return a failed or a
// successful URL request job.
-class DelayableCertReportURLRequestJob : public net::URLRequestJob,
- public base::NonThreadSafe {
+class DelayableCertReportURLRequestJob : public net::URLRequestJob {
public:
DelayableCertReportURLRequestJob(
bool delayed,
@@ -128,6 +127,9 @@ class DelayableCertReportURLRequestJob : public net::URLRequestJob,
bool should_fail_;
bool started_;
base::Callback<void()> destruction_callback_;
+
+ SEQUENCE_CHECKER(sequence_checker_);
+
base::WeakPtrFactory<DelayableCertReportURLRequestJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(DelayableCertReportURLRequestJob);
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698