Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2909063002: Revert of Remove InputMethodEventHandler.

Created:
3 years, 6 months ago by Hadi
Modified:
3 years, 6 months ago
CC:
chromium-reviews, kalyank, tfarina, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove InputMethodEventHandler. (patchset #16 id:300001 of https://codereview.chromium.org/2872343003/ ) Reason for revert: This CL makes TalkBack in Android window unusable. The issue is that after this CL, key event becomes to go through event rewriter in Chrome. TalkBack doesn't expect that events are rewritten by Chrome. Original issue's description: > Remove InputMethodEventHandler. > > This change removes InputMethodEventHandler and instead sends the events > to IME in WindowEventDispatcher::PreDispatchEvent(). > > > This is a step towards unifying key event processing path in classic ash and > mus+ash. > > BUG=719269 > > Review-Url: https://codereview.chromium.org/2872343003 > Cr-Commit-Position: refs/heads/master@{#472941} > Committed: https://chromium.googlesource.com/chromium/src/+/9f9dddf904a9eae86f20d0fa3f68c1881a360d80 TBR=sadrul@chromium.org,sky@chromium.org,reillyg@chromium.org,moshayedi@google.com,moshayedi@chromium.org BUG=719269, 727179, 726642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -42 lines) Patch
M ash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/window_tree_host_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 3 chunks +12 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_window_tree_host_platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_platform.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_unified.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A ash/ime/input_method_event_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ash/ime/input_method_event_handler.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M ash/mus/ash_window_tree_host_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/ash_window_tree_host_mus.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A extensions/shell/browser/input_method_event_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A extensions/shell/browser/input_method_event_handler.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.h View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 4 chunks +19 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_utils.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Hadi
PTAL.
3 years, 6 months ago (2017-05-29 14:43:07 UTC) #6
sky
Rubber stamp LGTM
3 years, 6 months ago (2017-05-30 16:35:10 UTC) #9
Reilly Grant (use Gerrit)
rs extensions lgtm
3 years, 6 months ago (2017-05-30 17:14:06 UTC) #10
Hadi
I am fixing the original issue at https://codereview.chromium.org/2916673002, so closing this one without landing. I'll ...
3 years, 6 months ago (2017-05-31 19:36:53 UTC) #11
David Tseng
On 2017/05/31 19:36:53, Hadi wrote: > I am fixing the original issue at https://codereview.chromium.org/2916673002, so ...
3 years, 6 months ago (2017-06-01 22:06:27 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:42:19 UTC) #14

Powered by Google App Engine
This is Rietveld 408576698