Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2909043002: Make dart2js understand relative part-of in platform libraries. (Closed)

Created:
3 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make dart2js understand relative part-of in platform libraries. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/5cbb22faf24dcb9ddcce2c12bd217dbea9a7c01a

Patch Set 1 #

Patch Set 2 : Allow both #

Total comments: 4

Patch Set 3 : git cl land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
3 years, 6 months ago (2017-05-29 12:41:45 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/2909043002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/2909043002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode783 pkg/compiler/lib/src/elements/modelx.dart:783: Uri uri = this.script.readableUri.resolve(content); This "readableUri", is that the ...
3 years, 6 months ago (2017-05-29 12:46:28 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2909043002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/2909043002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode783 pkg/compiler/lib/src/elements/modelx.dart:783: Uri uri = this.script.readableUri.resolve(content); On 2017/05/29 12:46:28, Lasse ...
3 years, 6 months ago (2017-05-29 12:52:31 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/2909043002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/2909043002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode786 pkg/compiler/lib/src/elements/modelx.dart:786: expectedUri = library.entryCompilationUnit.script.readableUri; On 2017/05/29 12:52:31, Johnni Winther wrote: ...
3 years, 6 months ago (2017-05-29 13:12:03 UTC) #5
Lasse Reichstein Nielsen
3 years, 6 months ago (2017-05-29 13:13:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5cbb22faf24dcb9ddcce2c12bd217dbea9a7c01a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698