Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.h

Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker. (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_tracker.h
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.h b/chrome/browser/page_load_metrics/page_load_tracker.h
index adfc4b85134d233d6e0355d558106902c35fc6d4..4a849c7797ef1699766d65d380c8a2ca27f1b034 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.h
+++ b/chrome/browser/page_load_metrics/page_load_tracker.h
@@ -15,6 +15,7 @@
#include "chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h"
#include "chrome/browser/page_load_metrics/user_input_tracker.h"
#include "chrome/common/page_load_metrics/page_load_timing.h"
+#include "components/ukm/ukm_source.h"
#include "content/public/browser/global_request_id.h"
#include "content/public/browser/web_contents_observer.h"
#include "ui/base/page_transition_types.h"
@@ -291,7 +292,7 @@ class PageLoadTracker : public PageLoadMetricsUpdateDispatcher::Client {
// committed load.
void LogAbortChainHistograms(content::NavigationHandle* final_navigation);
- void MaybeUpdateURL(content::NavigationHandle* navigation_handle);
+ void RecordUkmSourceInfo();
UserInputTracker input_tracker_;
@@ -370,6 +371,8 @@ class PageLoadTracker : public PageLoadMetricsUpdateDispatcher::Client {
PageLoadMetricsUpdateDispatcher metrics_update_dispatcher_;
+ const ukm::SourceId source_id_;
+
DISALLOW_COPY_AND_ASSIGN(PageLoadTracker);
};
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698