Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3525)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker. (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
index 3ceb5a409670f1c4fffb05a40963de9fe664b99f..79c3f35fa2224709d399e79f9d14587fff2ea1fa 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
@@ -9,7 +9,7 @@
#include "base/optional.h"
#include "base/time/time.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
-#include "components/ukm/ukm_service.h"
+#include "components/ukm/ukm_source.h"
#include "net/nqe/network_quality_estimator.h"
#include "ui/base/page_transition_types.h"
@@ -56,7 +56,8 @@ class UkmPageLoadMetricsObserver
const GURL& currently_committed_url,
bool started_in_foreground) override;
- ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
+ ObservePolicy OnCommit(content::NavigationHandle* navigation_handle,
+ ukm::SourceId source_id) override;
ObservePolicy FlushMetricsOnAppEnterBackground(
const page_load_metrics::mojom::PageLoadTiming& timing,
@@ -77,7 +78,8 @@ class UkmPageLoadMetricsObserver
// Records page load timing related metrics available in PageLoadTiming, such
// as first contentful paint.
void RecordTimingMetrics(
- const page_load_metrics::mojom::PageLoadTiming& timing);
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ ukm::SourceId source_id);
// Records metrics based on the PageLoadExtraInfo struct, as well as updating
// the URL. |app_background_time| should be set to a timestamp if the app was
@@ -89,9 +91,6 @@ class UkmPageLoadMetricsObserver
net::NetworkQualityEstimator::NetworkQualityProvider* const
network_quality_provider_;
- // Unique UKM identifier for the page load we are recording metrics for.
- const ukm::SourceId source_id_;
-
// Network quality estimates.
net::EffectiveConnectionType effective_connection_type_ =
net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN;

Powered by Google App Engine
This is Rietveld 408576698