chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h - Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h

Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker. (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h

index 5ef036d3d7c25d2d956e5b509cee08cc2afeedf5..08264e32d419cd3dc0627356559f92a35dc1943a 100644

--- a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"

+#include "components/ukm/ukm_source.h"

#include "ui/base/page_transition_types.h"

class OmniboxSuggestionUsedMetricsObserver

@@ -19,7 +20,8 @@ class OmniboxSuggestionUsedMetricsObserver

ObservePolicy OnHidden(

const page_load_metrics::mojom::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) override;

- ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;

+ ObservePolicy OnCommit(content::NavigationHandle* navigation_handle,

+ ukm::SourceId source_id) override;

void OnFirstContentfulPaintInPage(

const page_load_metrics::mojom::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) override;