chrome/browser/page_load_metrics/observers/google_captcha_observer.cc - Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker. (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/google_captcha_observer.h ('k') | chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

index abc00e4f9dd8ffe38d067505e10353d8485cbc5e..62426f2ddac1b0aea1bfbaa366b418d2721b6bda 100644

--- a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

@@ -45,7 +45,8 @@ bool IsGoogleCaptcha(const GURL& url) {

GoogleCaptchaObserver::GoogleCaptchaObserver() {}

page_load_metrics::PageLoadMetricsObserver::ObservePolicy

-GoogleCaptchaObserver::OnCommit(content::NavigationHandle* navigation_handle) {

+GoogleCaptchaObserver::OnCommit(content::NavigationHandle* navigation_handle,

+ ukm::SourceId source_id) {

if (!navigation_handle->IsSameDocument() &&

IsGoogleCaptcha(navigation_handle->GetURL())) {

RecordGoogleCaptchaEvent(GOOGLE_CAPTCHA_SHOWN);