chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc - Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

Issue 2909033002: Move UKM PageLoad SourceId generation to PageLoadTracker. (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

index 303039002225626d94005d12f6554a9477f974e8..49610fdb6f044314ee7054fef983b1af732a5330 100644

--- a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

@@ -81,7 +81,8 @@ AdsPageLoadMetricsObserver::~AdsPageLoadMetricsObserver() = default;

page_load_metrics::PageLoadMetricsObserver::ObservePolicy

AdsPageLoadMetricsObserver::OnCommit(

- content::NavigationHandle* navigation_handle) {

+ content::NavigationHandle* navigation_handle,

+ ukm::SourceId source_id) {

DCHECK(ad_frames_data_.empty());

committed_ = true;