Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 290903002: Changed JSON formatting to fit BigQuery requirements (Closed)

Created:
6 years, 7 months ago by kelvinly
Modified:
6 years, 7 months ago
Reviewers:
jcgregorio, benchen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Changed JSON formatting to fit BigQuery requirements BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14784

Patch Set 1 #

Patch Set 2 : Changed JSON format a little more #

Total comments: 2

Patch Set 3 : Fix for loop problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M bench/ResultsWriter.h View 1 2 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kelvinly
Changed the JSON format so it fits into a BigQuery a lot nicer It looks ...
6 years, 7 months ago (2014-05-19 14:50:48 UTC) #1
benchen
lgtm Joe, please also help take a look as you're more familiar with the codes. ...
6 years, 7 months ago (2014-05-19 16:12:45 UTC) #2
jcgregorio
https://codereview.chromium.org/290903002/diff/20001/bench/ResultsWriter.h File bench/ResultsWriter.h (right): https://codereview.chromium.org/290903002/diff/20001/bench/ResultsWriter.h#newcode108 bench/ResultsWriter.h:108: search_results = &(*iter); break; ?
6 years, 7 months ago (2014-05-19 17:05:12 UTC) #3
kelvinly
https://codereview.chromium.org/290903002/diff/20001/bench/ResultsWriter.h File bench/ResultsWriter.h (right): https://codereview.chromium.org/290903002/diff/20001/bench/ResultsWriter.h#newcode108 bench/ResultsWriter.h:108: search_results = &(*iter); On 2014/05/19 17:05:12, jcgregorio wrote: > ...
6 years, 7 months ago (2014-05-19 17:10:46 UTC) #4
kelvinly
Added break to for loop
6 years, 7 months ago (2014-05-19 17:13:06 UTC) #5
jcgregorio
On 2014/05/19 17:13:06, kelvinly wrote: > Added break to for loop lgtm
6 years, 7 months ago (2014-05-19 17:19:40 UTC) #6
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 7 months ago (2014-05-19 17:22:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/290903002/40001
6 years, 7 months ago (2014-05-19 17:22:59 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 17:29:04 UTC) #9
Message was sent while issue was closed.
Change committed as 14784

Powered by Google App Engine
This is Rietveld 408576698