Issue 2909011: Disabling BasicRestoreFromClosedWindow for chromeos as well.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2909011: Disabling BasicRestoreFromClosedWindow for chromeos as well. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by oshima

Modified:
3 years, 11 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Disabling BasicRestoreFromClosedWindow for chromeos as well. TBR=phajdan.jr@chromium.org, BUG=14774 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52158

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/tab_restore_uitest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

OK If there was some problems with the trybots, please alert maruel.

4 years, 10 months ago (2010-07-13 14:36:39 UTC) #2

oshima

4 years, 10 months ago (2010-07-13 15:50:41 UTC) #3

On Tue, Jul 13, 2010 at 7:36 AM, <phajdan.jr@chromium.org> wrote:

> OK
>
> If there was some problems with the trybots, please alert maruel.

It wasn't try bot that had problem. These failing tests were left and not
fixed
since there is no dbg build bot for chromeos and these failed tests are
passing
on release build. I'm setting up dbg buildbot for chromeos so we
won't have this issue again.

- oshima

>
>
> http://codereview.chromium.org/2909011/show
>

Expand Messages | Collapse Messages