Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6405)

Unified Diff: chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

Issue 2908983002: [reland] Bring up BrowserActionInteractiveTest on Mac. (Closed)
Patch Set: respond to comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc b/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
index 78e6cfe890433d729575288cfa9cbfab7708f9e8..0a5f6c0bfd723480cf0c09ff279d7ad6ceb6aebc 100644
--- a/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
+++ b/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
@@ -167,6 +167,12 @@ gfx::NativeView BrowserActionTestUtil::GetPopupNativeView() {
return popup_owner ? popup_owner->GetPopupNativeView() : nullptr;
}
+bool BrowserActionTestUtil::WaitForPopup() {
+ // TODO(tapted): Implement this for MacViews.
+ NOTIMPLEMENTED();
+ return HasPopup();
+}
+
bool BrowserActionTestUtil::HasPopup() {
return GetPopupNativeView() != nullptr;
}
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698