Add type inference logic for "for-in" loops.

Add type inference logic for "for-in" loops.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/6a809aa4329afe554be412fae86a89e8e0904d00

[Paul Berry, 2017-05-29 02:35:25]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[ahe, 2017-05-29 13:39:21]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-05-29 13:39:22]

lgtm

https://codereview.chromium.org/2908973002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2908973002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:471: // declared type
of the loop variable?
Notice also that the loop variable corresponds to a write to a variable in the
enclosing scope. So there may be some diagnostics that point to the wrong
location.

[Paul Berry, 2017-05-29 14:23:33]

https://codereview.chromium.org/2908973002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2908973002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:471: // declared type
of the loop variable?
On 2017/05/29 13:39:22, ahe wrote:
> Notice also that the loop variable corresponds to a write to a variable in the
> enclosing scope. So there may be some diagnostics that point to the wrong
> location.

Good point.  I've added a TODO to address this.

[Paul Berry, 2017-05-29 14:35:51]

Description was changed from

==========
Add type inference logic for "for-in" loops.
==========

to

==========
Add type inference logic for "for-in" loops.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6a809aa4329afe554be412fae86a89e8e0904d00
==========

[Paul Berry, 2017-05-29 14:35:52]

Committed patchset #1 (id:1) manually as
6a809aa4329afe554be412fae86a89e8e0904d00 (presubmit successful).

[scheglov, 2017-05-29 19:27:38]

LGTM