Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/renderer/resources/extensions/page_action_custom_bindings.js

Issue 2908883002: [Extensions Bindings] Remove some modules with native bindings (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the pageAction API. 5 // Custom binding for the pageAction API.
6 6
7 var binding = require('binding').Binding.create('pageAction'); 7 var binding = apiBridge || require('binding').Binding.create('pageAction');
8
9 var setIcon = require('setIcon').setIcon; 8 var setIcon = require('setIcon').setIcon;
10 var sendRequest = require('sendRequest').sendRequest; 9 var sendRequest = bindingUtil ?
10 $Function.bind(bindingUtil.sendRequest, bindingUtil) :
11 require('sendRequest').sendRequest;
11 12
12 binding.registerCustomHook(function(bindingsAPI) { 13 binding.registerCustomHook(function(bindingsAPI) {
13 var apiFunctions = bindingsAPI.apiFunctions; 14 var apiFunctions = bindingsAPI.apiFunctions;
14 15
15 apiFunctions.setHandleRequest('setIcon', function(details, callback) { 16 apiFunctions.setHandleRequest('setIcon', function(details, callback) {
16 setIcon(details, function(args) { 17 setIcon(details, $Function.bind(function(args) {
17 sendRequest(this.name, [args, callback], this.definition.parameters); 18 sendRequest('pageAction.setIcon', [args, callback],
18 }.bind(this)); 19 bindingUtil ? undefined : this.definition.parameters);
20 }, this));
19 }); 21 });
20 }); 22 });
21 23
22 exports.$set('binding', binding.generate()); 24 if (!apiBridge)
25 exports.$set('binding', binding.generate());
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698