Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: net/spdy/core/hpack/hpack_huffman_decoder.cc

Issue 2908763002: Change HpackHuffmanDecoder::CanonicalToSource() return type. (Closed)
Patch Set: Re: #15. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/core/hpack/hpack_huffman_decoder.h ('k') | net/spdy/core/hpack/hpack_huffman_decoder_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/core/hpack/hpack_huffman_decoder.cc
diff --git a/net/spdy/core/hpack/hpack_huffman_decoder.cc b/net/spdy/core/hpack/hpack_huffman_decoder.cc
index 3e2fc9c2f9028bd4308dcd2aa6dffac64145f0cd..85135795dfb16054db7ca9bb431e3dd637daf569 100644
--- a/net/spdy/core/hpack/hpack_huffman_decoder.cc
+++ b/net/spdy/core/hpack/hpack_huffman_decoder.cc
@@ -292,9 +292,9 @@ HuffmanWord HpackHuffmanDecoder::DecodeToCanonical(
return first_canonical + ordinal_in_length;
}
-char HpackHuffmanDecoder::CanonicalToSource(HuffmanWord canonical) {
+uint8_t HpackHuffmanDecoder::CanonicalToSource(HuffmanWord canonical) {
DCHECK_LT(canonical, 256u);
- return static_cast<char>(kCanonicalToSymbol[canonical]);
+ return kCanonicalToSymbol[canonical];
}
// TODO(jamessynge): Maybe further refactorings, including just passing in a
« no previous file with comments | « net/spdy/core/hpack/hpack_huffman_decoder.h ('k') | net/spdy/core/hpack/hpack_huffman_decoder_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698