Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: net/spdy/core/hpack/hpack_huffman_decoder.h

Issue 2908763002: Change HpackHuffmanDecoder::CanonicalToSource() return type. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/core/hpack/hpack_huffman_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/core/hpack/hpack_huffman_decoder.h
diff --git a/net/spdy/core/hpack/hpack_huffman_decoder.h b/net/spdy/core/hpack/hpack_huffman_decoder.h
index d33fa58174f3597da07db36caaa3f772538fefc1..a749752e40fc6efedf8c0fcbf323703d0049e035 100644
--- a/net/spdy/core/hpack/hpack_huffman_decoder.h
+++ b/net/spdy/core/hpack/hpack_huffman_decoder.h
@@ -59,7 +59,7 @@ class SPDY_EXPORT_PRIVATE HpackHuffmanDecoder {
// Converts a canonical symbol to the source symbol (the char in the original
xunjieli 2017/05/26 18:54:20 nit: comment still mentions "char"
Bence 2017/05/26 18:57:50 Done. My understanding is that "char" refers to c
// string that was encoded).
- static char CanonicalToSource(HuffmanWord canonical);
+ static uint8_t CanonicalToSource(HuffmanWord canonical);
};
} // namespace net
« no previous file with comments | « no previous file | net/spdy/core/hpack/hpack_huffman_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698