Issue 290873002: DevTools: allow embedder handling remote debugger commands.

Issue 290873002: DevTools: allow embedder handling remote debugger commands. (Closed)

Created:
6 years, 7 months ago by eustas

Modified:
6 years, 7 months ago

Reviewers:
jam, pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

DevTools: allow embedder handling remote debugger commands. BUG=373325 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271605

Patch Set 2 : Addressed comments #

Patch Set 3 : Removed unnecessary include #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -14 lines)			Patch
M	chrome/browser/devtools/chrome_devtools_manager_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/chrome_devtools_manager_delegate.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_protocol.h	View		4 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/browser/devtools/devtools_protocol.cc	View		4 chunks	+75 lines, -5 lines	0 comments	Download
M	content/browser/devtools/devtools_manager_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/devtools/devtools_protocol.h	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	content/browser/devtools/devtools_protocol.cc	View		2 chunks	+31 lines, -1 line	0 comments	Download
M	content/browser/devtools/render_view_devtools_agent_host.cc	View		2 chunks	+18 lines, -3 lines	0 comments	Download
M	content/public/browser/devtools_manager_delegate.h	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/290873002/diff/1/chrome/browser/devtools/chrome_devtools_manager_delegate.cc File chrome/browser/devtools/chrome_devtools_manager_delegate.cc (right): https://codereview.chromium.org/290873002/diff/1/chrome/browser/devtools/chrome_devtools_manager_delegate.cc#newcode34 chrome/browser/devtools/chrome_devtools_manager_delegate.cc:34: scoped_ptr<DevToolsProtocol::Command> command( Lets return NULL for now.

6 years, 7 months ago (2014-05-19 08:48:17 UTC) #2

eustas

https://codereview.chromium.org/290873002/diff/1/chrome/browser/devtools/chrome_devtools_manager_delegate.cc File chrome/browser/devtools/chrome_devtools_manager_delegate.cc (right): https://codereview.chromium.org/290873002/diff/1/chrome/browser/devtools/chrome_devtools_manager_delegate.cc#newcode34 chrome/browser/devtools/chrome_devtools_manager_delegate.cc:34: scoped_ptr<DevToolsProtocol::Command> command( On 2014/05/19 08:48:18, pfeldman wrote: > Lets ...

6 years, 7 months ago (2014-05-19 08:59:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/290873002/40001

6 years, 7 months ago (2014-05-20 04:54:47 UTC) #6

Message was sent while issue was closed.

Change committed as 271605

Expand Messages | Collapse Messages