device/blueooth: Add BlueZ unit test for BluetoothDevice::SetConnectionInterval.

device/bluetooth/dbus/fake_bluetooth_device_client.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/dbus/fake_bluetooth_device_client.h"
 
 #include <fcntl.h>
 #include <stddef.h>
 #include <sys/socket.h>
 #include <sys/types.h>
@@ skipping 583 matching lines @@
 
   callback.Run(connection_rssi_, transmit_power_, max_transmit_power_);
 }
 
 void FakeBluetoothDeviceClient::SetLEConnectionParameters(
     const dbus::ObjectPath& object_path,
     const ConnectionParameters& conn_params,
     const base::Closure& callback,
     const ErrorCallback& error_callback) {
   Properties* properties = GetProperties(object_path);
-  if (!properties->connected.value()) {
-    error_callback.Run(bluetooth_device::kErrorNotConnected, "Not Connected");
+  if (properties->type.value() == kTypeBredr) {

[ortuno, 2017/05/26 16:54:36]

I'm not that familiar with type as is not in upstream bluez.

Do we know if it's always going to be valid? What should we return if it isn't?

[Tim Song, 2017/05/26 19:56:18]

This property is exposed by the org.bluez.Device1 API:
https://cs.corp.google.com/chromeos_public/src/third_party/bluez/doc/device-a...

So I think it should be safe to assume this property is valid.

[ortuno, 2017/05/26 19:59:50]

It's optional though so it could still be invalid.

mcchou do you have any insight regarding 'type'?

[Miao, 2017/05/31 20:14:06]

Device Type is a CHROMIUM specific patch that upstream didn't adopt in my last
attempt, so it's not in BlueZ upstream.

The existence of property Type depends on the value of device->bredr and
device->le where their values are set during the creation of a device [1]. These
values are set initially during the device creation and updated later when
connecting to the device for the first time, searching the device based on
address type, or updating the address of the device. Theoretically, the device
can be invalid if none of these two value is set to true. However if looking
closer in BlueZ, you will find that at least one is set, and there is no method
to invalidate these two values during the lifetime of a device.

In Tim's previous patch of adding SetLEConnectionParameters method [2], the
underlying check on the type of a given device is based on the address type of
the device, but since the address type is not presented to upper layer. Checking
property Type is the closest way to mimic the actual check, and the value of
property Type also depends the address type. However, I agree with ortuno on the
validity of this property, so a check on the validity should be added here.

[1]
https://cs.corp.google.com/chromeos_public/src/third_party/bluez/src/device.c...
[2] https://chromium-review.googlesource.com/c/503432/

[Tim Song, 2017/06/01 18:06:03]

Done. I added the validity check.

+    error_callback.Run(bluetooth_device::kErrorFailed,
+                       "BR/EDR devices not supported");

[ortuno, 2017/05/26 16:54:36]

Should the call still work for non-connected devices?

[Tim Song, 2017/05/26 19:56:18]

Yes. One of the principle use cases is to set the connection parameters before
connecting.

I just screwed up implementing this fake method the first time around =p

[Miao, 2017/05/31 20:14:06]

The connection parameters can be set BEFORE or DURING the connection, so the
check on connected status is not needed.

[Tim Song, 2017/06/01 18:06:02]

Acknowledged.

     return;
   }
 
   callback.Run();
 }
 
 void FakeBluetoothDeviceClient::GetServiceRecords(
     const dbus::ObjectPath& object_path,
     const ServiceRecordsCallback& callback,
     const ErrorCallback& error_callback) {
@@ skipping 1243 matching lines @@
     properties->service_data.set_valid(true);
   }
 
   properties_map_.insert(std::make_pair(device_path, std::move(properties)));
   device_list_.push_back(device_path);
   for (auto& observer : observers_)
     observer.DeviceAdded(device_path);
 }
 
 }  // namespace bluez