ios/components/README - Issue 2908613002: Move common functionality of IOSChromeIOThread to ios/components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/components/README

Issue 2908613002: Move common functionality of IOSChromeIOThread to ios/components. (Closed)

Patch Set: Remove bug todo. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/components/README

diff --git a/ios/components/README b/ios/components/README

new file mode 100644

index 0000000000000000000000000000000000000000..8d81c853b9b3616e6933cf0176eb0d8065e10889

--- /dev/null

+++ b/ios/components/README

@@ -0,0 +1,12 @@

+This directory is for features that are intended for reuse. For example, code

+that is shared between multiple embedders of ios/web like ios/web_view and

+ios/chrome. This means that components must not depend on either ios/web_view or

Eugene But (OOO till 7-30) 2017/05/25 22:05:21 Can we/Should we enforce "must not depend" part in

michaeldo 2017/05/26 07:24:43 I added a - dep on them in DEPS with a note to see

+ios/chrome.

+Code which can be shared across Chrome on all platforms should go in

+//components (which also supports iOS specific sources).

+Code in a component should be placed in a namespace corresponding to

+the name of the component; e.g. for a component living in

+//components/foo, code in that component should be in the foo::

+namespace.