ios/components/README - Issue 2908613002: Move common functionality of IOSChromeIOThread to ios/components.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/components/README

Issue 2908613002: Move common functionality of IOSChromeIOThread to ios/components. (Closed)

Patch Set: Respond to comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 This directory is for features that are intended for reuse. For example, code
	sdefresne 2017/05/29 09:30:40 Can this file be a README.md file so that it displ Can this file be a README.md file so that it display nicely in gitiles? michaeldo 2017/05/30 17:16:24 Of course, thank you for catching this. Show quoted text On 2017/05/29 09:30:40, sdefresne wrote: > Can this file be a README.md file so that it display nicely in gitiles? Of course, thank you for catching this.
	2 that is shared between multiple embedders of ios/web like ios/web_view and

	3 ios/chrome. This means that components must not depend on either ios/web_view or

	4 ios/chrome.

	5

	6 Code which can be shared across Chrome on all platforms should go in

	7 //components (which also supports iOS specific sources).

	8

	9 Code in a component should be placed in a namespace corresponding to

	10 the name of the component; e.g. for a component living in

	11 //components/foo, code in that component should be in the foo::

	12 namespace.

OLD	NEW