ios/components/DEPS - Issue 2908613002: Move common functionality of IOSChromeIOThread to ios/components.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/components/DEPS

Issue 2908613002: Move common functionality of IOSChromeIOThread to ios/components. (Closed)

Patch Set: Respond to comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 # Do not add ios/chrome/ or ios/web_view as an allowed include. Please see

	3 # ios/components/README.

	4 "-ios/chrome",
	sdefresne 2017/05/29 09:30:40 I would instead use the following: "-ios", "+ I would instead use the following: "-ios", "+ios/web/public", "+ios/testing", Otherwise you probably also need to add "-ios/shared", "-ios/public", "-ios/showcase" which all depends on "ios/chrome" or are other embedders of "ios/web". michaeldo 2017/05/30 17:16:24 Done. Show quoted text On 2017/05/29 09:30:40, sdefresne wrote: > I would instead use the following: > > "-ios", > "+ios/web/public", > "+ios/testing", > > Otherwise you probably also need to add "-ios/shared", "-ios/public", > "-ios/showcase" which all depends on "ios/chrome" or are other embedders of > "ios/web". Done.
	5 "-ios/clean",

	6 "-ios/web_view",

	7

	8 # Individual components must explicitly declare their dependencies

	9 # on other components. Cycles in the dependency graph within

	10 # components/ are not allowed.

	11 "-components",

	12 ]

OLD	NEW