Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 2908543002: Add result interfaces used by AnalysisSession (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -65 lines) Patch
A pkg/analyzer/lib/dart/analysis/results.dart View 1 chunk +140 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 12 chunks +70 lines, -65 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
Obviously just a first step. The biggest differences between this and what we discussed previously ...
3 years, 7 months ago (2017-05-25 18:04:56 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2908543002/diff/1/pkg/analyzer/lib/dart/analysis/results.dart File pkg/analyzer/lib/dart/analysis/results.dart (right): https://codereview.chromium.org/2908543002/diff/1/pkg/analyzer/lib/dart/analysis/results.dart#newcode20 pkg/analyzer/lib/dart/analysis/results.dart:20: String get filePath; Could we drop "file" and ...
3 years, 7 months ago (2017-05-25 18:28:39 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2908543002/diff/1/pkg/analyzer/lib/dart/analysis/results.dart File pkg/analyzer/lib/dart/analysis/results.dart (right): https://codereview.chromium.org/2908543002/diff/1/pkg/analyzer/lib/dart/analysis/results.dart#newcode20 pkg/analyzer/lib/dart/analysis/results.dart:20: String get filePath; Done
3 years, 7 months ago (2017-05-25 19:43:58 UTC) #4
Brian Wilkerson
3 years, 7 months ago (2017-05-25 19:50:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50d0857f8259850e52fc2bbcacefd8d66044e6db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698