Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2278)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 290853003: cc: remove flaky LayerTreeHostTestFinishAllRendering (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index d1b518b44c8b1e250437f3be03c9eea062728c81..9d68b23cc343ca04a5fb7d6b0710659dbd4321a8 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -1526,47 +1526,6 @@ class LayerTreeHostTestAtomicCommitWithPartialUpdate
SINGLE_AND_MULTI_THREAD_DIRECT_RENDERER_TEST_F(
LayerTreeHostTestAtomicCommitWithPartialUpdate);
-class LayerTreeHostTestFinishAllRendering : public LayerTreeHostTest {
- public:
- LayerTreeHostTestFinishAllRendering() : once_(false), draw_count_(0) {}
-
- virtual void BeginTest() OVERRIDE {
- layer_tree_host()->SetNeedsRedraw();
- PostSetNeedsCommitToMainThread();
- }
-
- virtual void DidCommitAndDrawFrame() OVERRIDE {
- if (once_)
- return;
- once_ = true;
- layer_tree_host()->SetNeedsRedraw();
- {
- base::AutoLock lock(lock_);
- draw_count_ = 0;
- }
- layer_tree_host()->FinishAllRendering();
- {
- base::AutoLock lock(lock_);
- EXPECT_EQ(0, draw_count_);
- }
- EndTest();
- }
-
- virtual void DrawLayersOnThread(LayerTreeHostImpl* impl) OVERRIDE {
- base::AutoLock lock(lock_);
- ++draw_count_;
- }
-
- virtual void AfterTest() OVERRIDE {}
-
- private:
- bool once_;
- base::Lock lock_;
- int draw_count_;
-};
-
-SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestFinishAllRendering);
-
class LayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit
: public LayerTreeHostTest {
protected:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698