Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2908523002: Add a getNavigation request for plugins (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov, mfairhurst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -2 lines) Patch
M pkg/analyzer_plugin/doc/api.html View 2 chunks +75 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 1 chunk +296 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 1 chunk +57 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/plugin_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-25 17:40:42 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 17:43:54 UTC) #3
mfairhurst
LGTM too!
3 years, 7 months ago (2017-05-25 17:44:52 UTC) #4
Brian Wilkerson
3 years, 7 months ago (2017-05-25 17:51:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f5e1f260f96bb95145dc633441a342389206674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698