Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2908453002: Infer the types of initializing formals from the corresponding fields. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Infer the types of initializing formals from the corresponding fields. This inference is enabled for both strong and non-strong mode, since it is mandated by the Dart 1.0 spec. R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8a92a2a79c294692451274a1b02a1ba617992499

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -33 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart View 2 chunks +14 lines, -5 lines 1 comment Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 5 chunks +27 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/strong.status View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/DeltaBlue.dart.outline.expect View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/classes.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/classes.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/covariant_generic.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/constructors_infer_from_arguments_const.dart.strong.expect View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_const_with_upper_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/constructors_infer_from_arguments_const_with_upper_bound.dart.strong.expect View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_instance_creations_infer_downwards.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_initializing_formal_checks_default_value.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_constructor_from_arguments.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_constructor_from_arguments.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_constructor_from_arguments.dart.strong.expect View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/redirecting_factory.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/uninitialized_fields.dart.outline.expect View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-25 03:53:18 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 04:24:51 UTC) #3
ahe
Just to a quick look at one file. Go ahead :-) https://codereview.chromium.org/2908453002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart File pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart (right): ...
3 years, 7 months ago (2017-05-25 10:56:38 UTC) #4
Paul Berry
3 years, 7 months ago (2017-05-25 11:47:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8a92a2a79c294692451274a1b02a1ba617992499 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698