Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: net/cookies/cookie_store.h

Issue 2908443002: Initial implementation of Cookie service.
Patch Set: Partially written test. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_options.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_store.h
diff --git a/net/cookies/cookie_store.h b/net/cookies/cookie_store.h
index 1a4d3d47ed558f0653a418ed381077f0aa06e05d..461f607cd11d806769a62866e3831f18ece74d7c 100644
--- a/net/cookies/cookie_store.h
+++ b/net/cookies/cookie_store.h
@@ -42,7 +42,7 @@ class NET_EXPORT CookieStore {
// The following four values have the same meaning as EXPLICIT, but are
// being used to track down where a bug is coming from.
// TODO(nharper): Remove the following four values once the one of interest
- // has been found.
+ // has been found. See http://crbug.com/548423.
EXPLICIT_DELETE_BETWEEN,
EXPLICIT_DELETE_PREDICATE,
EXPLICIT_DELETE_SINGLE,
@@ -202,9 +202,11 @@ class NET_EXPORT CookieStore {
// Deletes all of the cookies that match the given predicate and that have a
// creation_date greater than or equal to |delete_begin| and smaller than
- // |delete_end|. This includes all http_only and secure cookies. Avoid
- // deleting cookies that could leave websites with a partial set of visible
- // cookies.
+ // |delete_end|. Null times do not cap their ranges (i.e.
+ // |delete_end.is_null()| would mean that there is no time after which
+ // cookies are not deleted). This includes all http_only and secure
+ // cookies. Avoid deleting cookies that could leave websites with a
+ // partial set of visible cookies.
// Calls |callback| with the number of cookies deleted.
virtual void DeleteAllCreatedBetweenWithPredicateAsync(
const base::Time& delete_begin,
« no previous file with comments | « net/cookies/cookie_options.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698