Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2908403002: Add a 'bot.dart' executable to the gardening tools. (Closed)

Created:
3 years, 6 months ago by floitsch
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -26 lines) Patch
A tools/gardening/bin/bot.dart View 1 chunk +40 lines, -0 lines 0 comments Download
M tools/gardening/bin/compare_failures.dart View 3 chunks +22 lines, -8 lines 0 comments Download
M tools/gardening/bin/create_shard_groups.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M tools/gardening/bin/current_summary.dart View 1 3 chunks +32 lines, -8 lines 0 comments Download
M tools/gardening/bin/status_summary.dart View 2 chunks +28 lines, -8 lines 0 comments Download
M tools/gardening/lib/src/util.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
3 years, 6 months ago (2017-05-30 16:48:25 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2908403002/diff/1/tools/gardening/bin/current_summary.dart File tools/gardening/bin/current_summary.dart (right): https://codereview.chromium.org/2908403002/diff/1/tools/gardening/bin/current_summary.dart#newcode58 tools/gardening/bin/current_summary.dart:58: if (argResults['verbose']) { Just do `log('Reading $buildUri');` - ...
3 years, 6 months ago (2017-05-31 07:37:26 UTC) #3
floitsch
https://codereview.chromium.org/2908403002/diff/1/tools/gardening/bin/current_summary.dart File tools/gardening/bin/current_summary.dart (right): https://codereview.chromium.org/2908403002/diff/1/tools/gardening/bin/current_summary.dart#newcode58 tools/gardening/bin/current_summary.dart:58: if (argResults['verbose']) { On 2017/05/31 07:37:26, Johnni Winther wrote: ...
3 years, 6 months ago (2017-05-31 14:36:18 UTC) #4
floitsch
3 years, 6 months ago (2017-05-31 14:36:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5aa5295e08d9113321fdbfdb03f946a93e86e294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698