Nonvirtual pointer visitor in GCs

runtime/vm/gc_marker.cc

Index: runtime/vm/gc_marker.cc
diff --git a/runtime/vm/gc_marker.cc b/runtime/vm/gc_marker.cc
index fd1a1f25b8f5cde5d8e2344770429ba55bac27ac..ef11a9467867e676bc1d7dc75e407f3d6953d8be 100644
--- a/runtime/vm/gc_marker.cc
+++ b/runtime/vm/gc_marker.cc
@@ -192,7 +192,7 @@ class MarkingVisitorBase : public ObjectPointerVisitor {
         // The key is marked so we make sure to properly visit all pointers
         // originating from this weak property.
         VisitingOldObject(cur_weak);
-        cur_weak->VisitPointers(this);
+        cur_weak->VisitPointersNonvirtual(this);
       } else {
         // Requeue this weak property to be handled later.
         EnqueueWeakProperty(cur_weak);
@@ -220,7 +220,7 @@ class MarkingVisitorBase : public ObjectPointerVisitor {
         VisitingOldObject(raw_obj);
         const intptr_t class_id = raw_obj->GetClassId();
         if (class_id != kWeakPropertyCid) {
-          marked_bytes_ += raw_obj->VisitPointers(this);
+          marked_bytes_ += raw_obj->VisitPointersNonvirtual(this);
         } else {
           RawWeakProperty* raw_weak =
               reinterpret_cast<RawWeakProperty*>(raw_obj);
@@ -272,7 +272,7 @@ class MarkingVisitorBase : public ObjectPointerVisitor {
       return raw_weak->Size();
     }
     // Key is gray or black. Make the weak property black.
-    return raw_weak->VisitPointers(this);
+    return raw_weak->VisitPointersNonvirtual(this);

[erikcorry, 2017/05/31 10:40:42]

I don't think this is worth it.  Normally there are a lot more non-weak pointers
on the heap than weak pointers. ALso another place in this file.

   }
 
   // Called when all marking is complete.