Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl.h

Issue 2908243002: Remove QuicChromiumClientStream::Delegate in favor of async methods. (Closed)
Patch Set: No expect_trailers_ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/bidirectional_stream_quic_impl.h
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.h b/net/quic/chromium/bidirectional_stream_quic_impl.h
index 1b3864661fd14666f77fc486d98be40c07cb560b..8ec93aeee10ba650a9bbd09cd51136a2f5c235d5 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.h
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.h
@@ -29,8 +29,7 @@ struct BidirectionalStreamRequestInfo;
class IOBuffer;
class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
- : public BidirectionalStreamImpl,
- public QuicChromiumClientStream::Delegate {
+ : public BidirectionalStreamImpl {
public:
explicit BidirectionalStreamQuicImpl(
std::unique_ptr<QuicChromiumClientSession::Handle> session);
@@ -54,14 +53,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override;
private:
- // QuicChromiumClientStream::Delegate implementation:
- void OnClose() override;
- void OnError(int error) override;
-
- // Write headers to the stream and returns true on success. Posts a task to
- // notify the delegate asynchronously and returns false on failure
- bool WriteHeaders();
-
+ int WriteHeaders();
void OnStreamReady(int rv);
void OnSendDataComplete(int rv);
void ReadInitialHeaders();
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698