Source/core/rendering/RenderFlexibleBox.cpp - Issue 290823003: Chrome incorrectly honors "align-content" in "flex-wrap: wrap" flex containers that only have a sin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlexibleBox.cpp

Issue 290823003: Chrome incorrectly honors "align-content" in "flex-wrap: wrap" flex containers that only have a sin… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified LayoutTests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFlexibleBox.cpp

diff --git a/Source/core/rendering/RenderFlexibleBox.cpp b/Source/core/rendering/RenderFlexibleBox.cpp

index 2395e4a874a331f929f40bc64fa489fd9b48fc2c..c197eafc27cbb99dd2710e4e524a75d285f425d3 100644

--- a/Source/core/rendering/RenderFlexibleBox.cpp

+++ b/Source/core/rendering/RenderFlexibleBox.cpp

@@ -1209,6 +1209,8 @@ void RenderFlexibleBox::layoutColumnReverse(const OrderedFlexItemList& children,

static LayoutUnit initialAlignContentOffset(LayoutUnit availableFreeSpace, EAlignContent alignContent, unsigned numberOfLines)

{

+ if (numberOfLines <= 1)

+ return 0;

if (alignContent == AlignContentFlexEnd)

return availableFreeSpace;

if (alignContent == AlignContentCenter)

« no previous file with comments | « LayoutTests/css3/flexbox/multiline-align-content.html ('k') | no next file » | no next file with comments »