Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: storage/browser/quota/quota_temporary_storage_evictor.cc

Issue 2908223002: Deprecate NonThreadSafe in storage/browser/quota in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « storage/browser/quota/quota_temporary_storage_evictor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/browser/quota/quota_temporary_storage_evictor.cc
diff --git a/storage/browser/quota/quota_temporary_storage_evictor.cc b/storage/browser/quota/quota_temporary_storage_evictor.cc
index b7af58c793aa845d0e596aa3de5c1dac3bdb3d01..4eb97885f30a49843a398ab2ca5dccbb132dace0 100644
--- a/storage/browser/quota/quota_temporary_storage_evictor.cc
+++ b/storage/browser/quota/quota_temporary_storage_evictor.cc
@@ -56,6 +56,7 @@ QuotaTemporaryStorageEvictor::QuotaTemporaryStorageEvictor(
}
QuotaTemporaryStorageEvictor::~QuotaTemporaryStorageEvictor() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
}
void QuotaTemporaryStorageEvictor::GetStatistics(
@@ -135,7 +136,7 @@ void QuotaTemporaryStorageEvictor::OnEvictionRoundFinished() {
}
void QuotaTemporaryStorageEvictor::Start() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
base::AutoReset<bool> auto_reset(&timer_disabled_for_testing_, false);
StartEvictionTimerWithDelay(0);
@@ -228,7 +229,7 @@ void QuotaTemporaryStorageEvictor::OnGotEvictionRoundInfo(
}
void QuotaTemporaryStorageEvictor::OnGotEvictionOrigin(const GURL& origin) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (origin.is_empty()) {
StartEvictionTimerWithDelay(interval_ms_);
@@ -246,7 +247,7 @@ void QuotaTemporaryStorageEvictor::OnGotEvictionOrigin(const GURL& origin) {
void QuotaTemporaryStorageEvictor::OnEvictionComplete(
QuotaStatusCode status) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
// Just calling ConsiderEviction() or StartEvictionTimerWithDelay() here is
// ok. No need to deal with the case that all of the Delete operations fail
« no previous file with comments | « storage/browser/quota/quota_temporary_storage_evictor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698