Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: pkg/compiler/lib/src/js_emitter/type_test_registry.dart

Issue 2908153003: It's alive! (Closed)
Patch Set: Updated cf. comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/type_test_registry.dart
diff --git a/pkg/compiler/lib/src/js_emitter/type_test_registry.dart b/pkg/compiler/lib/src/js_emitter/type_test_registry.dart
index 83b79eb825c4fa4bc306af327cd4acad3ef9b857..adb9c2593fa5446ee55bc17a1dcec2d2b6a328f2 100644
--- a/pkg/compiler/lib/src/js_emitter/type_test_registry.dart
+++ b/pkg/compiler/lib/src/js_emitter/type_test_registry.dart
@@ -6,8 +6,7 @@ library dart2js.js_emitter.type_test_registry;
import '../common.dart';
import '../common_elements.dart';
-import '../elements/elements.dart'
- show ClassElement, ElementKind, MemberElement, MethodElement;
+import '../elements/elements.dart' show ClassElement, MethodElement;
import '../elements/entities.dart';
import '../elements/resolution_types.dart'
show
@@ -142,10 +141,11 @@ class TypeTestRegistry {
}
}
- bool canTearOff(MemberElement function) {
+ bool canTearOff(MemberEntity function) {
if (!function.isFunction ||
function.isConstructor ||
- function.isAccessor) {
+ function.isGetter ||
+ function.isSetter) {
return false;
} else if (function.isInstanceMember) {
if (!function.enclosingClass.isClosure) {
@@ -155,21 +155,18 @@ class TypeTestRegistry {
return false;
}
- bool canBeReflectedAsFunction(MemberElement element) {
- return element.kind == ElementKind.FUNCTION ||
- element.kind == ElementKind.GETTER ||
- element.kind == ElementKind.SETTER ||
- element.kind == ElementKind.GENERATIVE_CONSTRUCTOR;
+ bool canBeReflectedAsFunction(MemberEntity element) {
+ return !element.isField;
}
- bool canBeReified(MemberElement element) {
+ bool canBeReified(MemberEntity element) {
return (canTearOff(element) ||
mirrorsData.isMemberAccessibleByReflection(element));
}
// Find all types referenced from the types of elements that can be
// reflected on 'as functions'.
- liveMembers.where((MemberElement element) {
+ liveMembers.where((MemberEntity element) {
return canBeReflectedAsFunction(element) && canBeReified(element);
}).forEach((MethodElement function) {
FunctionType type = function.type;

Powered by Google App Engine
This is Rietveld 408576698