Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_strategy.dart

Issue 2908153003: It's alive! (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/kernel_strategy.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_strategy.dart b/pkg/compiler/lib/src/kernel/kernel_strategy.dart
index 844459dbcde5d2b5e1142dccafc2f0b0125b1948..33dbafbcf75cf402f53a221697e0ba35ffc05171 100644
--- a/pkg/compiler/lib/src/kernel/kernel_strategy.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_strategy.dart
@@ -181,7 +181,10 @@ class MirrorsDataBuilderImpl extends MirrorsDataImpl {
@override
void computeMembersNeededForReflection(
- ResolutionWorldBuilder worldBuilder, ClosedWorld closedWorld) {}
+ ResolutionWorldBuilder worldBuilder, ClosedWorld closedWorld) {
+ // TODO(johnniwinther): Support dart:mirrors.
+ createImmutableSets();
+ }
@override
void maybeMarkClosureAsNeededForReflection(
@@ -239,12 +242,12 @@ class MirrorsResolutionAnalysisImpl implements MirrorsResolutionAnalysis {
class MirrorsCodegenAnalysisImpl implements MirrorsCodegenAnalysis {
@override
int get preMirrorsMethodCount {
- throw new UnimplementedError(
- 'MirrorsCodegenAnalysisImpl.preMirrorsMethodCount');
+ // TODO(johnniwinther): Implement this.
+ return null;
}
@override
void onQueueEmpty(Enqueuer enqueuer, Iterable<ClassEntity> recentClasses) {
- throw new UnimplementedError('MirrorsCodegenAnalysisImpl.onQueueEmpty');
+ // TODO(johnniwinther): Implement this.
}
}

Powered by Google App Engine
This is Rietveld 408576698