Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 2908153003: It's alive! (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
index 8693416d711fd24b02f79bfc8ad1dfdeebde480b..1039af714de7f35b0fc4058bf93c183a0773d692 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
@@ -13,6 +13,7 @@ part of dart2js.js_emitter.program_builder;
class Collector {
final CompilerOptions _options;
final CommonElements _commonElements;
+ final ElementEnvironment _elementEnvironment;
final DeferredLoadTask _deferredLoadTask;
final CodegenWorldBuilder _worldBuilder;
// TODO(floitsch): the code-emitter task should not need a namer.
@@ -54,6 +55,7 @@ class Collector {
Collector(
this._options,
this._commonElements,
+ this._elementEnvironment,
this._deferredLoadTask,
this._worldBuilder,
this._namer,
@@ -153,9 +155,9 @@ class Collector {
final onlyForRti = classesOnlyNeededForRti.contains(cls);
if (!onlyForRti) {
_mirrorsData.retainMetadataOfClass(cls);
- new FieldVisitor(_options, _worldBuilder, _nativeData, _mirrorsData,
- _namer, _closedWorld)
- .visitFields(cls, false, (FieldElement member,
+ new FieldVisitor(_options, _elementEnvironment, _worldBuilder,
+ _nativeData, _mirrorsData, _namer, _closedWorld)
+ .visitFields((FieldElement member,
js.Name name,
js.Name accessorName,
bool needsGetter,
@@ -166,7 +168,7 @@ class Collector {
_mirrorsData.isMemberAccessibleByReflection(member)) {
_mirrorsData.retainMetadataOfMember(member);
}
- });
+ }, cls: cls);
}
}
typedefsNeededForReflection.forEach(_mirrorsData.retainMetadataOfTypedef);

Powered by Google App Engine
This is Rietveld 408576698