Issue 2908153002: Revert "Fix misoptimization of 'is' test"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2908153002: Revert "Fix misoptimization of 'is' test" (Closed)

Created:
3 years, 6 months ago by erikcorry

Modified:
3 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Fix misoptimization of 'is' test" R=johnniwinther@google.com BUG= This reverts commits fc693153d1c79e8303abe05697a1d8458b0fef62 and b7797ac45fe6d58d5dae6c4db3094afb1dfaa4bc, code review at https://codereview.chromium.org/2904543002. Revert is due to an AOT failure. Committed: https://github.com/dart-lang/sdk/commit/1839f6375b0d2feb15d262d18c1ecb5f4840b5af

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/standalone/regress_29695_test.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

3 years, 6 months ago (2017-05-29 13:25:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1839f6375b0d2feb15d262d18c1ecb5f4840b5af (presubmit successful).