Index: content/public/browser/permission_manager.h |
diff --git a/content/public/browser/permission_manager.h b/content/public/browser/permission_manager.h |
index 54de7a2ad9beb309917fb6da914f392baa663b7c..a5e62b49c9af8a295b78b8373eeb7f9876587cd3 100644 |
--- a/content/public/browser/permission_manager.h |
+++ b/content/public/browser/permission_manager.h |
@@ -63,13 +63,18 @@ class CONTENT_EXPORT PermissionManager { |
// kNoPendingOperation is a no-op. |
virtual void CancelPermissionRequest(int request_id) = 0; |
- // Returns the permission status of a given requesting_origin/embedding_origin |
- // tuple. This is not taking a RenderFrameHost because the call might happen |
- // outside of a frame context. |
- virtual blink::mojom::PermissionStatus GetPermissionStatus( |
- PermissionType permission, |
- const GURL& requesting_origin, |
- const GURL& embedding_origin) = 0; |
+ // Returns the PermissionStatus for a specific RenderFrameHost. |
+ virtual blink::mojom::PermissionStatus GetPermissionStatusForFrame( |
mlamouri (slow - plz ping)
2017/06/08 13:35:52
Can we drop "ForFrame" and "ForWorkers" and instea
raymes
2017/06/12 03:24:17
Hmm could you explain what you mean a bit more by:
mlamouri (slow - plz ping)
2017/06/15 13:02:08
I think johnme@ mentioned one place.
|
+ content::PermissionType permission, |
+ content::RenderFrameHost* render_frame_host, |
+ const GURL& requesting_origin) = 0; |
+ |
+ // Returns the PermissionStatus for a worker. This should not be used for |
+ // determining the permission status for a request coming from a |
+ // RenderFrameHost. |
+ virtual blink::mojom::PermissionStatus GetPermissionStatusForWorker( |
+ content::PermissionType permission, |
+ const GURL& requesting_origin) = 0; |
mlamouri (slow - plz ping)
2017/06/08 13:35:52
No strong opinion on this but maybe we can keep th
raymes
2017/06/12 03:24:17
(Hopefully addressed in the above comment)
|
// Sets the permission back to its default for the requesting_origin/ |
// embedding_origin tuple. |