Split GetPermissionStatus into GetPermissionStatusForFrame/Worker

headless/lib/browser/headless_permission_manager.cc

Index: headless/lib/browser/headless_permission_manager.cc
diff --git a/headless/lib/browser/headless_permission_manager.cc b/headless/lib/browser/headless_permission_manager.cc
index a75ee4c3481ee6acde41c7c45634e544f61953b1..398bfd2e0e7104ddb1dcc751dddf3bc30a09f5e9 100644
--- a/headless/lib/browser/headless_permission_manager.cc
+++ b/headless/lib/browser/headless_permission_manager.cc
@@ -47,13 +47,21 @@ void HeadlessPermissionManager::ResetPermission(
     const GURL& requesting_origin,
     const GURL& embedding_origin) {}
 
-blink::mojom::PermissionStatus HeadlessPermissionManager::GetPermissionStatus(
+blink::mojom::PermissionStatus
+HeadlessPermissionManager::GetPermissionStatusForFrame(
     content::PermissionType permission,
-    const GURL& requesting_origin,
-    const GURL& embedding_origin) {
+    content::RenderFrameHost* render_frame_host,
+    const GURL& requesting_origin) {
   return blink::mojom::PermissionStatus::ASK;
 }
 
+blink::mojom::PermissionStatus
+HeadlessPermissionManager::GetPermissionStatusForWorker(
+    content::PermissionType permission,
+    const GURL& requesting_origin) {
+  return blink::mojom::PermissionStatus::DENIED;

[Sami, 2017/06/07 10:15:25]

Could you explain why this is DENIED instead of ASK? It seems a little
inconsistent. If we do decide to keep this DENIED, let's add a comment
explaining why.

[raymes, 2017/06/07 23:03:35]

You can never prompt from a worker, so DENIED is more appropriate. I added a
comment.

[mlamouri (slow - plz ping), 2017/06/15 13:02:08]

Why doing that instead of returning the current status? RequestPermission()
should return the current status if it can't prompt.

+}
+
 int HeadlessPermissionManager::SubscribePermissionStatusChange(
     content::PermissionType permission,
     const GURL& requesting_origin,