Split GetPermissionStatus into GetPermissionStatusForFrame/Worker

chrome/browser/geolocation/geolocation_permission_context_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <string>
@@ skipping 820 matching lines @@
                                GeolocationPermissionContextAndroid::
                                    LocationSettingsDialogBackOff::kThreeMonths),
                            2);
 }
 
 TEST_P(GeolocationPermissionContextTests, LSDBackOffPermissionStatus) {
   base::test::ScopedFeatureList scoped_feature_list;
   EnableFeature(&scoped_feature_list, features::kLsdPermissionPrompt);
 
   GURL requesting_frame("https://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ALLOW);
 
   // Turn off system location but allow the LSD to be shown, and denied.
   MockLocationSettings::SetLocationStatus(true /* android */,
                                           false /* system */);
   MockLocationSettings::SetLocationSettingsDialogStatus(true /* enabled */,
                                                         DENIED);
 
   // The permission status should reflect that the LSD will be shown.
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
   EXPECT_TRUE(RequestPermissionIsLSDShown(requesting_frame));
 
   // Now that the LSD is in backoff, the permission status should reflect it.
   EXPECT_FALSE(RequestPermissionIsLSDShown(requesting_frame));
-  ASSERT_EQ(blink::mojom::PermissionStatus::DENIED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::DENIED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 }
 
 TEST_P(GeolocationPermissionContextTests, LSDBackOffAskPromptsDespiteBackOff) {
   base::test::ScopedFeatureList scoped_feature_list;
   EnableFeature(&scoped_feature_list, features::kLsdPermissionPrompt);
 
   GURL requesting_frame("https://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ALLOW);
 
   // Turn off system location but allow the LSD to be shown, and denied.
   MockLocationSettings::SetLocationStatus(true /* android */,
                                           false /* system */);
   MockLocationSettings::SetLocationSettingsDialogStatus(true /* enabled */,
                                                         DENIED);
 
   // First, cancel a LSD prompt on the first non-DSE origin to go into backoff.
   EXPECT_TRUE(RequestPermissionIsLSDShown(requesting_frame));
   EXPECT_FALSE(RequestPermissionIsLSDShown(requesting_frame));
 
   // Set the content setting back to ASK. The permission status should be
   // prompt, and the LSD prompt should now be shown.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ASK);
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
   EXPECT_TRUE(
       RequestPermissionIsLSDShownWithPermissionPrompt(requesting_frame));
 }
 
 TEST_P(GeolocationPermissionContextTests,
        LSDBackOffAcceptPermissionResetsBackOff) {
   base::test::ScopedFeatureList scoped_feature_list;
   EnableFeature(&scoped_feature_list, features::kLsdPermissionPrompt);
 
   GURL requesting_frame("https://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ALLOW);
 
   // Turn off system location but allow the LSD to be shown, and denied.
   MockLocationSettings::SetLocationStatus(true /* android */,
                                           false /* system */);
   MockLocationSettings::SetLocationSettingsDialogStatus(true /* enabled */,
                                                         DENIED);
 
   // First, get into the highest backoff state.
@@ skipping 342 matching lines @@
       CONTENT_SETTING_ASK,
       GetGeolocationContentSetting(requesting_frame_1, requesting_frame_0));
 }
 
 #if defined(OS_ANDROID)
 TEST_P(GeolocationPermissionContextTests, SearchGeolocationInIncognito) {
   base::test::ScopedFeatureList scoped_feature_list;
   EnableFeature(&scoped_feature_list, features::kConsistentOmniboxGeolocation);
 
   GURL requesting_frame(TestSearchEngineDelegate::kDSETestUrl);
+  NavigateAndCommit(requesting_frame);
   // The DSE Geolocation setting should be used in incognito if it is BLOCK,
   // but not if it is ALLOW.
   SearchGeolocationService* geo_service =
       SearchGeolocationService::Factory::GetForBrowserContext(profile());
   geo_service->SetSearchEngineDelegateForTest(
       base::MakeUnique<TestSearchEngineDelegate>());
 
   Profile* otr_profile = profile()->GetOffTheRecordProfile();
 
   // A DSE setting of ALLOW should not flow through to incognito.
   geo_service->SetDSEGeolocationSetting(true);
   ASSERT_EQ(CONTENT_SETTING_ASK,
             PermissionManager::Get(otr_profile)
-                ->GetPermissionStatus(CONTENT_SETTINGS_TYPE_GEOLOCATION,
-                                      requesting_frame, requesting_frame)
+                ->GetPermissionStatusForFrame(CONTENT_SETTINGS_TYPE_GEOLOCATION,
+                                              main_rfh(), requesting_frame)
                 .content_setting);
 
   // Changing the setting to BLOCK should flow through to incognito.
   geo_service->SetDSEGeolocationSetting(false);
   ASSERT_EQ(CONTENT_SETTING_BLOCK,
             PermissionManager::Get(otr_profile)
-                ->GetPermissionStatus(CONTENT_SETTINGS_TYPE_GEOLOCATION,
-                                      requesting_frame, requesting_frame)
+                ->GetPermissionStatusForFrame(CONTENT_SETTINGS_TYPE_GEOLOCATION,
+                                              main_rfh(), requesting_frame)
                 .content_setting);
 }
 
 TEST_P(GeolocationPermissionContextTests,
        GeolocationStatusAndroidDisabledLegacy) {
   GURL requesting_frame("https://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
 
   // In these tests the Android permission status should not be taken into
   // account, only the content setting.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ALLOW);
   MockLocationSettings::SetLocationStatus(false /* android */,
                                           true /* system */);
-  ASSERT_EQ(blink::mojom::PermissionStatus::GRANTED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::GRANTED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ASK);
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_BLOCK);
-  ASSERT_EQ(blink::mojom::PermissionStatus::DENIED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::DENIED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 }
 
 TEST_P(GeolocationPermissionContextTests, GeolocationStatusAndroidDisabled) {
   base::test::ScopedFeatureList scoped_feature_list;
   EnableFeature(&scoped_feature_list, features::kLsdPermissionPrompt);
 
   GURL requesting_frame("https://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
 
   // With the Android permission off, but location allowed for a domain, the
   // permission status should be ASK.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ALLOW);
   MockLocationSettings::SetLocationStatus(false /* android */,
                                           true /* system */);
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   // With the Android permission off, and location blocked for a domain, the
   // permission status should still be BLOCK.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_BLOCK);
-  ASSERT_EQ(blink::mojom::PermissionStatus::DENIED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::DENIED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   // With the Android permission off, and location prompt for a domain, the
   // permission status should still be ASK.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ASK);
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 }
 
 TEST_P(GeolocationPermissionContextTests,
        GeolocationStatusSystemDisabledLegacy) {
   GURL requesting_frame("https://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
 
   // In these tests the system permission status should not be taken into
   // account, only the content setting.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ALLOW);
   MockLocationSettings::SetLocationStatus(true /* android */,
                                           false /* system */);
-  ASSERT_EQ(blink::mojom::PermissionStatus::GRANTED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::GRANTED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ASK);
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_BLOCK);
-  ASSERT_EQ(blink::mojom::PermissionStatus::DENIED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::DENIED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 }
 
 TEST_P(GeolocationPermissionContextTests, GeolocationStatusSystemDisabled) {
   base::test::ScopedFeatureList scoped_feature_list;
   EnableFeature(&scoped_feature_list, features::kLsdPermissionPrompt);
 
   GURL requesting_frame("https://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
 
   // With the system permission off, but location allowed for a domain, the
   // permission status should be reflect whether the LSD can be shown.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ALLOW);
   MockLocationSettings::SetLocationStatus(true /* android */,
                                           false /* system */);
   MockLocationSettings::SetLocationSettingsDialogStatus(true /* enabled */,
                                                         DENIED);
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   MockLocationSettings::SetLocationSettingsDialogStatus(false /* enabled */,
                                                         GRANTED);
-  ASSERT_EQ(blink::mojom::PermissionStatus::DENIED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::DENIED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   // The result should be the same if the location permission is ASK.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_ASK);
   MockLocationSettings::SetLocationSettingsDialogStatus(true /* enabled */,
                                                         GRANTED);
-  ASSERT_EQ(blink::mojom::PermissionStatus::ASK,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::ASK,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   MockLocationSettings::SetLocationSettingsDialogStatus(false /* enabled */,
                                                         GRANTED);
-  ASSERT_EQ(blink::mojom::PermissionStatus::DENIED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::DENIED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 
   // With the Android permission off, and location blocked for a domain, the
   // permission status should still be BLOCK.
   SetGeolocationContentSetting(requesting_frame, requesting_frame,
                                CONTENT_SETTING_BLOCK);
   MockLocationSettings::SetLocationSettingsDialogStatus(true /* enabled */,
                                                         GRANTED);
-  ASSERT_EQ(blink::mojom::PermissionStatus::DENIED,
-            PermissionManager::Get(profile())->GetPermissionStatus(
-                content::PermissionType::GEOLOCATION, requesting_frame,
-                requesting_frame));
+  ASSERT_EQ(
+      blink::mojom::PermissionStatus::DENIED,
+      PermissionManager::Get(profile())->GetPermissionStatusForFrame(
+          content::PermissionType::GEOLOCATION, main_rfh(), requesting_frame));
 }
 #endif  // defined(OS_ANDROID)
 
 #if defined(OS_ANDROID)
 INSTANTIATE_TEST_CASE_P(
     GeolocationPermissionContextTestsInstance,
     GeolocationPermissionContextTests,
     ::testing::Values(TestType::PERMISSION_REQUEST_MANAGER,
                       TestType::PERMISSION_QUEUE_CONTROLLER));
 #else
 INSTANTIATE_TEST_CASE_P(
     GeolocationPermissionContextTestsInstance,
     GeolocationPermissionContextTests,
     ::testing::Values(TestType::PERMISSION_REQUEST_MANAGER));
 #endif