Split GetPermissionStatus into GetPermissionStatusForFrame/Worker

headless/lib/browser/headless_permission_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "headless/lib/browser/headless_permission_manager.h"
 
 #include "base/callback.h"
 #include "content/public/browser/permission_type.h"
 
 namespace headless {
@@ skipping 29 matching lines @@
   return kNoPendingOperation;
 }
 
 void HeadlessPermissionManager::CancelPermissionRequest(int request_id) {}
 
 void HeadlessPermissionManager::ResetPermission(
     content::PermissionType permission,
     const GURL& requesting_origin,
     const GURL& embedding_origin) {}
 
-blink::mojom::PermissionStatus HeadlessPermissionManager::GetPermissionStatus(
+blink::mojom::PermissionStatus
+HeadlessPermissionManager::GetPermissionStatusForFrame(
     content::PermissionType permission,
-    const GURL& requesting_origin,
-    const GURL& embedding_origin) {
+    content::RenderFrameHost* render_frame_host,
+    const GURL& requesting_origin) {
   return blink::mojom::PermissionStatus::ASK;
 }
 
+blink::mojom::PermissionStatus
+HeadlessPermissionManager::GetPermissionStatusForWorker(
+    content::PermissionType permission,
+    const GURL& requesting_origin) {
+  return blink::mojom::PermissionStatus::DENIED;

[Sami, 2017/06/07 10:15:25]

Could you explain why this is DENIED instead of ASK? It seems a little
inconsistent. If we do decide to keep this DENIED, let's add a comment
explaining why.

[raymes, 2017/06/07 23:03:35]

You can never prompt from a worker, so DENIED is more appropriate. I added a
comment.

[mlamouri (slow - plz ping), 2017/06/15 13:02:08]

Why doing that instead of returning the current status? RequestPermission()
should return the current status if it can't prompt.

+}
+
 int HeadlessPermissionManager::SubscribePermissionStatusChange(
     content::PermissionType permission,
     const GURL& requesting_origin,
     const GURL& embedding_origin,
     const base::Callback<void(blink::mojom::PermissionStatus)>& callback) {
   return kNoPendingOperation;
 }
 
 void HeadlessPermissionManager::UnsubscribePermissionStatusChange(
     int subscription_id) {}
 
 }  // namespace headless