third_party/WebKit/LayoutTests/external/wpt/netinfo/Netinfo.html - Issue 2908103002: NetInfo external Web LayoutTest

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/netinfo/Netinfo.html

Issue 2908103002: NetInfo external Web LayoutTest (Closed)

Patch Set: ps Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>NetInfo Test</title>

	4 <link rel="help" href="https://wicg.github.io/netinfo/">

	5 <meta name="flags" content="">
	foolip 2017/05/29 19:28:00 This line isn't necessary. Since the filename isn This line isn't necessary. Since the filename isn't in the diff, also using this place to suggest naming this netinfo-basics.html or something similar, since presumably there will be other tests eventually to disambiguate this from. tbansal1 2017/05/30 21:49:41 Done. Show quoted text On 2017/05/29 19:28:00, foolip wrote: > This line isn't necessary. > > Since the filename isn't in the diff, also using this place to suggest naming > this netinfo-basics.html or something similar, since presumably there will be > other tests eventually to disambiguate this from. Done.
	6 <script src="/resources/testharness.js"></script>

	7 <script src="/resources/testharnessreport.js"></script>

	8

	9 <h2>Description</h2>
	foolip 2017/05/29 19:28:00 These bits, while often found in LayoutTests, aren These bits, while often found in LayoutTests, aren't necessary in web-platform-tests. If you like you can put extra information in comments, or in the title itself. tbansal1 2017/05/30 21:49:41 Done. Show quoted text On 2017/05/29 19:28:00, foolip wrote: > These bits, while often found in LayoutTests, aren't necessary in > web-platform-tests. If you like you can put extra information in comments, or in > the title itself. Done.
	10 <p>

	11 This test validates that all of the NetInfo attributes exist and are set to

	12 their correct values.

	13 </p>

	14

	15 <script>

	16 test(function() {
	foolip 2017/05/29 19:28:00 It's a good idea in general to have separate tests It's a good idea in general to have separate tests if it's plausible that one might fail some assertions but still usefully pass some others, which would be the case if someone implements, say, rtt/downlink but no other attributes. One test for attribute would probably make the most sense, and then it's OK to also omit the assert descriptions if they end up being almost the same as the test title. tbansal1 2017/05/30 21:49:41 Done. Using one test per attribute. Show quoted text On 2017/05/29 19:28:00, foolip wrote: > It's a good idea in general to have separate tests if it's plausible that one > might fail some assertions but still usefully pass some others, which would be > the case if someone implements, say, rtt/downlink but no other attributes. > > One test for attribute would probably make the most sense, and then it's OK to > also omit the assert descriptions if they end up being almost the same as the > test title. Done. Using one test per attribute.
	17 assert_greater_than_equal(navigator.connection.downlinkMax, 0,

	18 'downlinkMax must be non-negative');

	19

	20 assert_true(navigator.connection.type == "bluetooth"
	foolip 2017/05/29 19:28:00 assert_in_array would help for this and effectiveT assert_in_array would help for this and effectiveType. tbansal1 2017/05/30 21:49:41 Thanks, this makes the test much cleaner. Show quoted text On 2017/05/29 19:28:00, foolip wrote: > assert_in_array would help for this and effectiveType. Thanks, this makes the test much cleaner.
	21 \|\| navigator.connection.type == "cellular"

	22 \|\| navigator.connection.type == "ethernet"

	23 \|\| navigator.connection.type == "mixed"

	24 \|\| navigator.connection.type == "none"

	25 \|\| navigator.connection.type == "other"

	26 \|\| navigator.connection.type == "unknown"

	27 \|\| navigator.connection.type == "wifi"

	28 \|\| navigator.connection.type == "wimax",

	29 'type is unexpected');

	30

	31 assert_greater_than_equal(navigator.connection.rtt, 0,
	foolip 2017/05/29 19:28:00 Can you also assert_equals(navigator.connection.rt Can you also assert_equals(navigator.connection.rtt % 25, 0) and similar for downlink? tbansal1 2017/05/30 21:49:41 Done. Show quoted text On 2017/05/29 19:28:00, foolip wrote: > Can you also assert_equals(navigator.connection.rtt % 25, 0) and similar for > downlink? Done.
	32 'rtt must be non-negative');

	33

	34 assert_greater_than_equal(navigator.connection.downlink, 0,

	35 'downlink must be non-negative');

	36

	37 assert_true(navigator.connection.effectiveType == "slow-2g"

	38 \|\| navigator.connection.effectiveType == "2g"

	39 \|\| navigator.connection.effectiveType == "3g"

	40 \|\| navigator.connection.effectiveType == "4g",

	41 'effectiveType is unexpected');

	42 });

	43 </script>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »