third_party/WebKit/LayoutTests/external/wpt/netinfo/netinfo-downlink.html - Issue 2908103002: NetInfo external Web LayoutTest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/netinfo/netinfo-downlink.html

Issue 2908103002: NetInfo external Web LayoutTest (Closed)

Patch Set: foolip comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>NetInfo Test</title>
	foolip 2017/05/31 14:18:14 If the test itself doesn't have a title (after the If the test itself doesn't have a title (after the function) then this will be used. Can you make the title something that includes "downlink"? (Omitting "test" and similar is fine.) tbansal1 2017/06/06 20:07:40 Done. Show quoted text On 2017/05/31 14:18:14, foolip wrote: > If the test itself doesn't have a title (after the function) then this will be > used. Can you make the title something that includes "downlink"? (Omitting > "test" and similar is fine.) Done.
	4 <link rel="help" href="https://wicg.github.io/netinfo/">

	5 <script src="/resources/testharness.js"></script>

	6 <script src="/resources/testharnessreport.js"></script>

	7

	8 <script>

	9 test(function() {

	10 assert_greater_than_equal(navigator.connection.downlink, 0, '');
	foolip 2017/05/31 14:18:14 An empty description won't do anything, just omit An empty description won't do anything, just omit it. tbansal1 2017/06/06 20:07:40 Done. I have removed the description from places w Show quoted text On 2017/05/31 14:18:14, foolip wrote: > An empty description won't do anything, just omit it. Done. I have removed the description from places where it was not providing any value over the existing assert condition.
	11 assert_equals((navigator.connection.downlink *1000) % 25, 0,

	12 'downlink must be a multiple of 25 kbps');

	13 });

	14 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/netinfo/netinfo-downlink-max.html » ('j') | no next file with comments »