Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2908073008: Remove a frame of delay on main-thread FlingStart. [2nd land] (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebActiveGestureAnimation.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 12e2e3b5158be4287dad2dbcdbe675b124fe4413..f6a890a5ba39f4bbe686b9d61f9d09263f0dfebb 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -699,8 +699,8 @@ WebInputEventResult WebViewImpl::HandleGestureEvent(
event.data.fling_start.velocity_y),
WebSize());
DCHECK(fling_curve);
- gesture_animation_ = WebActiveGestureAnimation::CreateAtAnimationStart(
dtapuska 2017/05/31 00:53:11 Do we want this to be the event creation time or N
aelias_OOO_until_Jul13 2017/05/31 01:07:06 My rule of thumb is that in cases of jank during a
- std::move(fling_curve), this);
+ gesture_animation_ = WebActiveGestureAnimation::CreateWithTimeOffset(
+ std::move(fling_curve), this, event.TimeStampSeconds());
MainFrameImpl()->FrameWidget()->ScheduleAnimation();
event_result = WebInputEventResult::kHandledSystem;
« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebActiveGestureAnimation.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698