chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc - Issue 2908073003: Ensure that mask layer is of the same size as the owning layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2908073003: Ensure that mask layer is of the same size as the owning layer. (Closed)

Patch Set: clean up my mistake Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

index 624d469dc5e4e8b72a3eedd68689f357ec6c8b15..6062d7a790d29b73dd4664e0ff8d04b4e9be24a0 100644

--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

@@ -55,7 +55,7 @@ class PermissionsBubbleDialogDelegateView

~PermissionsBubbleDialogDelegateView() override;

void CloseBubble();

- void SizeToContents();

+ void SizeToContents() override;

stevenjb 2017/06/14 17:58:58 Assuming this overrides a BubbleDialogDelegateView

sunxd 2017/06/14 18:19:56 Done.

// BubbleDialogDelegateView:

bool ShouldShowCloseButton() const override;

« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | ui/views/bubble/bubble_dialog_delegate.h » ('j') | no next file with comments »