Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3426)

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2907983002: Allow dialogs to use a custom View as their title. (Closed)
Patch Set: pass strings by reference Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
index 624d469dc5e4e8b72a3eedd68689f357ec6c8b15..fc47080b2218baf8d26310bebfc179d86462edff 100644
--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
@@ -59,8 +59,8 @@ class PermissionsBubbleDialogDelegateView
// BubbleDialogDelegateView:
bool ShouldShowCloseButton() const override;
- const gfx::FontList& GetTitleFontList() const override;
base::string16 GetWindowTitle() const override;
+ views::View* CreateTitleView(const base::string16& title_text) override;
void OnWidgetDestroying(views::Widget* widget) override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
bool Cancel() override;
@@ -150,17 +150,20 @@ bool PermissionsBubbleDialogDelegateView::ShouldShowCloseButton() const {
return true;
}
-const gfx::FontList& PermissionsBubbleDialogDelegateView::GetTitleFontList()
- const {
- ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- return rb.GetFontList(ui::ResourceBundle::BaseFont);
-}
-
base::string16 PermissionsBubbleDialogDelegateView::GetWindowTitle() const {
return l10n_util::GetStringFUTF16(IDS_PERMISSIONS_BUBBLE_PROMPT,
display_origin_);
}
+views::View* PermissionsBubbleDialogDelegateView::CreateTitleView(
+ const base::string16& title_text) {
+ views::Label* title =
+ views::BubbleFrameView::CreateDefaultTitleLabel(title_text);
+ title->SetFontList(ui::ResourceBundle::GetSharedInstance().GetFontList(
+ ui::ResourceBundle::BaseFont));
+ return title;
+}
+
void PermissionsBubbleDialogDelegateView::SizeToContents() {
BubbleDialogDelegateView::SizeToContents();
}

Powered by Google App Engine
This is Rietveld 408576698