Allow dialogs to use a custom View as their title.

ui/views/window/dialog_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/dialog_delegate.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 73 matching lines @@
   // Web-modal (ui::MODAL_TYPE_CHILD) dialogs with parents are marked as child
   // widgets to prevent top-level window behavior (independent movement, etc).
   // On Mac, however, the parent may be a native window (not a views::Widget),
   // and so the dialog must be considered top-level to gain focus and input
   // method behaviors.
   params.child = parent && (delegate->GetModalType() == ui::MODAL_TYPE_CHILD);
 #endif
   return params;
 }
 
+StyledLabel* DialogDelegate::CreateTitleView() {
+  return nullptr;

[Peter Kasting, 2017/06/07 02:40:43]

Why not have this return a StyledLabel for GetWindowTitle()?

Then the caller doesn't need to worry about checking one or the other, it can
just check this.

Where I'd like to go with this is to make GetWindowTitle() private -- so the
window title is only exposed to callers through this method.  There aren't that
many callers of it today.  However, looking at that highlights that
DialogDelegate::GetAccessibleNodeData() assumes it can read the window title
from GetWindowTitle().  If a class overrides CreateTitleView() and doesn't also
provide a parallel accessible version in GetWindowTitle(), they'll do the wrong
thing.

If GetAccessibleNodeData() read the text out of the label returned here, that
would work; but returning a new label each time just to read the data seems bad.
 If DialogDelegate owned the StyledLabel and CreateTitleView() just updated the
member, we could access that way; but proper ownership becomes a bit of an issue
then (probably the view has to be unique_ptr'd to this class and
set_owned_by_parent(false), and I don't know if that can cause destruction order
issues).

Still, I don't have a better idea unless you want to limit this entirely to
BubbleFrameView.

[Bret, 2017/06/07 20:15:41]

I'll keep this in mind as I rework it, and see if I can find a way to enforce
that the label title matches GetWindowTitle (even if it's just with a DCHECK).

+}
+
 View* DialogDelegate::CreateExtraView() {
-  return NULL;
+  return nullptr;
 }
 
 bool DialogDelegate::GetExtraViewPadding(int* padding) {
   return false;
 }
 
 View* DialogDelegate::CreateFootnoteView() {
   return NULL;
 }
 
@@ skipping 162 matching lines @@
   node_data->role = ui::AX_ROLE_DIALOG;
 }
 
 void DialogDelegateView::ViewHierarchyChanged(
     const ViewHierarchyChangedDetails& details) {
   if (details.is_add && details.child == this && GetWidget())
     NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
 }
 
 }  // namespace views