Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 290793004: Use a BitArray in RuntimeCSSEnabled instead of a Vector<bool> (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
Reviewers:
dstockwell, eseidel, ojan
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, Mikhail, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews-wtf_chromium.org, rune+blink, rwlbuis, Mike Lawther (Google)
Visibility:
Public.

Description

Use a BitArray in RuntimeCSSEnabled instead of a Vector<bool> Use a BitArray in RuntimeCSSEnabled instead of a Vector<bool> to keep track of which features are enabled at runtime in order to use a little less memory. This CL also adds a value argument to the WTF::BitArray constructor so that bits can be initialized to 1 instead of 0, as RuntimeCSSEnabled expects all bits to be initially 1. A clear() method is also added so that bits can be unset and not simply set. R=eseidel@chromium.org, dstockwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174531

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use BitArray instead #

Patch Set 3 : Fix bug in clear() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M Source/core/css/RuntimeCSSEnabled.cpp View 1 4 chunks +12 lines, -9 lines 0 comments Download
M Source/wtf/BitArray.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Inactive
6 years, 7 months ago (2014-05-18 19:54:31 UTC) #1
Inactive
6 years, 7 months ago (2014-05-20 23:29:40 UTC) #2
eseidel
lgtm I feel like I tried this once and didn't for some reason. In any ...
6 years, 7 months ago (2014-05-21 00:42:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/290793004/1
6 years, 7 months ago (2014-05-21 00:43:12 UTC) #4
dstockwell
Last minute nits, feel free to ignore :P https://codereview.chromium.org/290793004/diff/1/Source/core/css/RuntimeCSSEnabled.cpp File Source/core/css/RuntimeCSSEnabled.cpp (right): https://codereview.chromium.org/290793004/diff/1/Source/core/css/RuntimeCSSEnabled.cpp#newcode133 Source/core/css/RuntimeCSSEnabled.cpp:133: static ...
6 years, 7 months ago (2014-05-21 00:45:40 UTC) #5
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 7 months ago (2014-05-21 00:48:08 UTC) #6
Inactive
https://codereview.chromium.org/290793004/diff/1/Source/core/css/RuntimeCSSEnabled.cpp File Source/core/css/RuntimeCSSEnabled.cpp (right): https://codereview.chromium.org/290793004/diff/1/Source/core/css/RuntimeCSSEnabled.cpp#newcode133 Source/core/css/RuntimeCSSEnabled.cpp:133: static BitVector* switches = 0; On 2014/05/21 00:45:41, dstockwell ...
6 years, 7 months ago (2014-05-21 01:04:48 UTC) #7
Inactive
I updated the CL to use a BitArray instead of a BitVector. Please take another ...
6 years, 7 months ago (2014-05-21 02:43:57 UTC) #8
dstockwell
lgtm
6 years, 7 months ago (2014-05-21 02:46:35 UTC) #9
Inactive
Eric, could you please take another look at wtf/ as well? The code there is ...
6 years, 7 months ago (2014-05-21 02:57:33 UTC) #10
eseidel
lgtm
6 years, 7 months ago (2014-05-21 22:35:30 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 08:09:48 UTC) #12
Message was sent while issue was closed.
Change committed as 174531

Powered by Google App Engine
This is Rietveld 408576698